Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter_and: New linter, or part of conjunct_test_linter()? #2073

Closed
MichaelChirico opened this issue Aug 10, 2023 · 1 comment · Fixed by #2077
Closed

filter_and: New linter, or part of conjunct_test_linter()? #2073

MichaelChirico opened this issue Aug 10, 2023 · 1 comment · Fixed by #2077

Comments

@MichaelChirico
Copy link
Collaborator

One linter for #884 looks for dplyr::filter(x, A && B) and recommends dplyr::filter(x, A, B).

Should this be a new linter (we call it filter_and_condition_linter(), but I think conjunct_filter_linter() would fit the {lintr} style better), or be subsumed as part of the existing conjunct_test_linter()?

@AshesITR
Copy link
Collaborator

Seems like a good place to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants