Fix up CI, improve typing, remove dead imports, and other minor changes #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 28, 2024
C0rn3j
changed the title
NikOverflow
requested changes
Jan 2, 2025
|
Should be done |
|
i look into the rest tomorrow. The vulnerabilities shouldn't affect us. |
|
Anything left to do here on my side? |
|
i guess not but i can't test it at the moment because i have no time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump version to 4.4.0 (hope that follows your versioning schemes, did it since I was already touching it up anyway)
Fix up CI using deprecated actions - not 100% sure if those will run now (since they require approval), but fingers crossed, so far never had trouble upgrading through a simple version bump. Should hopefully get rid of the failing CI linter, or at least of the node version warnings in the CI if not that.
Fix up Python versions in setup.py to use currently supported versions by upstream.
Fix broken typing in function parameters.
Add py.typed and tag the packages as supporting typing, to allow tools use the type hints that there are already even though the package is not fully typed yet - https://typing.readthedocs.io/en/latest/spec/distributing.html#packaging-typed-libraries
Remove outdated List, Union and Optional typing imports.
Remove unused imports.
Remove nonexistent win64 platform check - https://docs.python.org/3/library/sys.html#sys.platform
Tagging a new release would be welcome after this is pulled.