Add Dockerfile and make docker target #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, why is this PR not ready to merge? Is something missing or is this waiting for v3? |
|
It is ready. @vahidrezanezhad @michalbubula this adds a Dockerfile, so we can run eynollah in docker, podman or kubernetes. It does not change anything in the code and should be compatible with all branches, so merging should have no adverse effects. With the default base image, there won't be support for GPU though but that can be rectified later (we do have cuda-tf2 core base images that should enable that but since we cannot use GPU in our cluster right now, it's low prio for us atm) |
cneud
reviewed
Oct 1, 2024
kba
commented
Oct 1, 2024
cneud
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.