Improve handling of channel numbers in UI to prevent spurious errors #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the GUI look a bit, making the "extra" options center-aligned with some padding. Hopefully resolve the weirdness when the 3 color deconvolved channels would count as selected, but not show up visually as selected, if switching from multiplex to brightfield. Change the handling of channels to read the channel information from the RDF spec and enable/disable running/error messages appropriately. Running models is disabled and a warning shown if: - the currently selected model doesn't support arbitrary channel numbers - the number of currently selected channels doesn't match the number the model wants This means you can do funny stuff like: - select 3 channels in a multiplexed image and run a brightfield model on it - Run a brightfield model on the color deconvolved channels of an RGB image - Run a fluorescence model on brightfield (color deconvolved or RGB) - Support weird models like the 2 channel tissuenet one
alanocallaghan
requested review from
petebankhead,
finglis and
ThibautGoldsborough
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #47 and #48 I hope.
Change the GUI look a bit, making the "extra" options center-aligned with some padding.
Hopefully resolve the weirdness when the 3 color deconvolved channels would
count as selected, but not show up visually as selected, if switching from multiplex
to brightfield.
Change the handling of channels to read the channel information from the RDF spec
and enable/disable running/error messages appropriately.
Running models is disabled and a warning shown if:
This means you can do funny stuff like: