Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add detection measurements #38

Merged
merged 8 commits into from
Aug 5, 2024
Merged

Add detection measurements #38

merged 8 commits into from
Aug 5, 2024

Conversation

alanocallaghan
Copy link
Collaborator

No description provided.

@alanocallaghan
Copy link
Collaborator Author

It would be more idiomatic to have a shapeFeatures(Collection<ObjectMeasurements.ShapeFeatures> shapeFeatures) method in the builder, but we'd have to add a ObjectMeasurements.addShapeMeasurements(PathObject o, PixelCalibration p, Collection<ShapeFeatures> f) method to ObjectMeasurements

@alanocallaghan
Copy link
Collaborator Author

alanocallaghan commented Jul 11, 2024 •
edited
Loading

Could also use telescoping method calls in this case, but Collection<PathObject>, Collection<ObjectMeasurements.Compartments>, Collection<ObjectMeasurements.ShapeFeatures>, Collection<ObjectMeasurements.Measurements> "have the same erasure"

@alanocallaghan alanocallaghan mentioned this pull request Jul 12, 2024
Closed
@alanocallaghan alanocallaghan merged commit b7926a0 into main Aug 5, 2024
1 check passed
@alanocallaghan alanocallaghan deleted the measurements branch August 5, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alanocallaghan