Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix channel selector when duplicate channels present (resolve #11) #13

Merged
merged 9 commits into from
Apr 25, 2024

Conversation

alanocallaghan
Copy link
Collaborator

Asking for @petebankhead to have a look as this type of behaviour should(?) also be fixed in the pixel classifier, I'd say?

@petebankhead
Copy link
Member

Erm, not sure. I think with the pixel classifier, the intention was to store the channel name in the json - not the number. Since the channels might get shuffled. Or, indeed, names might not be parsed properly. Using the name makes this much more easily correct-able than requiring the image to be rewritten with channels in the 'right' order.

Clearly the use of names doesn't handle duplicates, but if you've got duplicates then Something Bad Has Happened anyway.

@alanocallaghan
Copy link
Collaborator Author

Yeah, maybe the solution is a more strongly-worded warning for anything that tries to use channel names when there are duplicates. Though I guess we'd want to be able to point to a solution (python/groovy script to rename channels, maybe?)

Copy link
Collaborator Author

@alanocallaghan alanocallaghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some restructuring, but generally this should be a good setup for scripting and interactive use

@alanocallaghan alanocallaghan merged commit 5fe05d1 into main Apr 25, 2024
1 check passed
@alanocallaghan alanocallaghan deleted the channel-selector branch April 25, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants