Replaced the Image selection dialog with a searchable ListSelectionView #8
Conversation
| tfFilter.textProperty().bindBidirectional(filterText); | ||
| filterText.addListener((v, o, n) -> updateImageList(list, entries, alreadySelected, n)); | ||
|
|
||
| if (tfFilter.getText() != "") |
There was a problem hiding this comment.
There was a problem hiding this comment.
I'm not sure if it's also possible to have null, or blank (but non-empty) strings.
(FWIW I recently learned about getValueSafe() for StringProperty, which helps a bit with the first of these)
|
Hello, I see there are conflicts with the gradle files. If that helps, I have a version of this extension where I modified all the files to better match the extension template. Since I made those changes, I see there has been / will be a new pull request in the pipeline. When the new template is ready, I will adapt my changes and propose a new pull request if that helps (just to bring the main branch up to template spec). Cheers, |
|
Thanks @zindy! The new template should be pretty much ready - we just haven't merged it yet because it'll be wrong for anyone who wants to build an extension for v0.5.x... I think there is no turning back from the changes though :) We want to update all our extensions for v0.6.0 and then include them in a new extension index to make it possible to check compatibility across QuPath. So we plan to make a new release candidate of this one very soon... along with QuPath v0.6.0-rc4 |
| } | ||
|
|
||
| /** | ||
| * We should just be able to call {@link ListSelectionView#getSourceItems()}, but in ControlsFX 11 there |
There was a problem hiding this comment.
I think this workaround is no longer needed with ControlsFX 11.1.2 as used in QuPath now.
This is just a small enhancement in UX, which I wanted to keep separate from my other PR.
It replaces the image selection box in qupath-extension-align with a ListSelectionView, which is searchable. For large projects with many entries (patient IDs), the search facility has been really helpful for finding matching images.
I've tested both my PRs separately and together.
Here's the post I made which describes the changes in more details: https://forum.image.sc/t/improving-the-qupath-extension-align-ui-hopefully/67390
Cheers,
Egor