Check for image MIME data before HTML data #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copying an image from Firefox attaches some HTML to the image. Extracting the plain text from the HTML before the image results in empty data in the field, with no image, triggering an assertion failure on message send. This is a partial fix for issue quotient-im#867. Partial, because the resulting image does not appear in the chat window until relaunching, due to an error opening the temp file created by this.
KitsuneRal
approved these changes
May 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copying an image from Firefox attaches some HTML to the image. Extracting the plain text from the HTML before the image results in empty data in the field, with no image, triggering an assertion failure on message send.
This is a partial fix for issue #867. Partial, because the resulting image does not appear in the chat window until relaunching, due to an error opening the temp file created by this.