fix self check

quora · Sep 27, 2024 · 3c0dcd5 · 3c0dcd5
1 parent b6a5b27
commit 3c0dcd5
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/pyanalyze/implementation.py b/pyanalyze/implementation.py
@@ -34,6 +34,7 @@
 from .signature import (
     ANY_SIGNATURE,
     CallContext,
+    ConcreteSignature,
     ImplReturn,
     OverloadedSignature,
     ParameterKind,
@@ -2238,7 +2239,11 @@ def get_default_argspecs() -> Dict[object, Signature]:
 
 def check_regex(pattern: Union[str, bytes]) -> Optional[CanAssignError]:
     try:
-        re.compile(pattern)
+        # TODO allow this without the useless isinstance()
+        if isinstance(pattern, str):
+            re.compile(pattern)
+        else:
+            re.compile(pattern)
     except re.error as e:
         return CanAssignError(
             f"Invalid regex pattern: {e}", error_code=ErrorCode.invalid_regex
@@ -2275,7 +2280,7 @@ def _re_impl_with_pattern(ctx: CallContext) -> Value:
 
 def get_default_argspecs_with_cache(
     asc: "pyanalyze.arg_spec.ArgSpecCache",
-) -> Dict[object, Signature]:
+) -> Dict[object, ConcreteSignature]:
     sigs = {}
     for func in (
         re.compile,