Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix finite lorax generation in cb mode #216

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

quic-jouachen
Copy link
Contributor

@quic-jouachen quic-jouachen commented Jan 9, 2025

The examples/lora_models.py script encounters issues in cb mode. This PR addresses the following:

  • Resolves the regression in finite lorax generation within cb mode in QEfficient/generation/text_generation_inference.py that occurred after the last refactoring.
  • Adds an additional unit test in tests/peft/lora/test_lora_model.py to verify the compile-generate flow for finite lorax cb mode.
  • [Addressed after comments] Uses auto device picking in tests/peft/lora/test_lora_model.py; Updates auto device picking option for generate() in QEfficient/peft/lora/auto.py

@quic-jouachen quic-jouachen force-pushed the finitelorax_generation_fix branch 3 times, most recently from cccff25 to c66e9aa Compare January 9, 2025 03:59
@quic-jouachen quic-jouachen force-pushed the finitelorax_generation_fix branch 3 times, most recently from 7cf7c17 to 2a023c8 Compare January 9, 2025 18:24
@quic-rishinr quic-rishinr force-pushed the finitelorax_generation_fix branch from 8ab204d to 8602096 Compare January 11, 2025 09:23
@quic-rishinr quic-rishinr merged commit 05275e5 into quic:main Jan 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants