Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncm-systemd schema: port fix from configuration-module-core/main #240

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

jouvin
Copy link
Contributor

@jouvin jouvin commented Dec 17, 2024

No description provided.

- Fix ncm-systemd schema validation, see quattor/configuration-modules-core#1787
- Manually ported in this repo to allow test-library CI script to succed
@jouvin jouvin added this to the 25.next milestone Dec 17, 2024
@jouvin jouvin requested a review from jrha December 17, 2024 21:28
@jouvin
Copy link
Contributor Author

jouvin commented Dec 17, 2024

Required to fix failing test-library tests in quattor/template-library-examples#42 and other open PRs.

@jouvin
Copy link
Contributor Author

jouvin commented Dec 17, 2024

@jrha test-library is failing as it requires quattor/template-library-examples#42 to be merged... There is a chicken & egg problem here. One of the 2 PRs (this one or the other for the examples) must be merged ignoring the CI error for the other to succeed!

I have intentionally not ported the fixes for the indentation errors to remain minimalistic in this manual fix to a file normally updated automatically during the release process...

@jrha jrha merged commit 5f63b84 into quattor:main Dec 18, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants