Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panlint: Unittest fixes #267

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

panlint: Unittest fixes #267

wants to merge 8 commits into from

Conversation

jrha
Copy link
Member

@jrha jrha commented Dec 10, 2024

Based on #266.

@jrha jrha added the panlint label Dec 10, 2024
@jrha jrha added this to the 10.8 milestone Dec 12, 2024
@jrha jrha force-pushed the unittests branch 2 times, most recently from 39dfb8a to 4422ec4 Compare December 16, 2024 11:49
jrha added 8 commits December 16, 2024 11:49
- Fix global variable names in Pan snippets
- Use a similar dict structure to the good tests for the bad tests
- Test behaviour around negative numbers
- Test all operators at least once
- Use _assert_lint_line consistently
- Don't use variables where they aren't needed
- Use _assert_lint_line throughout
@jrha jrha marked this pull request as ready for review December 16, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant