metaconfig/named: fix validation of logging channels in categories #1783
+14
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jouvin
force-pushed
the
metaconfig_named_logging_channel_validation
branch
from
b569118 to
744bac3
Compare
jrha
reviewed
Dec 9, 2024
|
Fixes for existing issues in #1785. |
jouvin
force-pushed
the
metaconfig_named_logging_channel_validation
branch
3 times, most recently
from
e768b75 to
fb128b2
Compare
jouvin
force-pushed
the
metaconfig_named_logging_channel_validation
branch
from
fb128b2 to
94c00a9
Compare
|
@jrha hopefully, I manage to fix the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1784
This PR fixes the issue and add a category in the test profile to ensure that this validation statement is tested.