Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncm-sudo: support all values for lecture option and the lecture_file option #1689

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stdweird
Copy link
Member

@stdweird stdweird commented Jul 3, 2024

this is backwards incompatible

@jrha needs to be checked if this supported on el7 or el6

@ned21
Copy link
Contributor

ned21 commented Jul 7, 2024

If I understand the comment correctly, a file with the old true/false values is accepted by sshd. However any site that sets config via quattor to true/false will need to modify all their templates to use once/never instead. That's a one-time sed fixup, but needs to happen in sync with the schema change and the code on the hosts needs to be ready to accept new version before the schema change can happen.

Is there a way to permit both forms to co-exist for a release or two to provide a smooth transition path? Maybe something like

type sudo_lecture_transition = property with {
    if( is_binary(SELF) ) {
        warning("Deprecated ...);
    } else {
        # manual form of "choice" for transition, replace with choice when transition complete
        if( !match(SELF, '^(always|once|never$') ) {
            error(...);
        }
   }
   true;
};

@jrha jrha added this to the 25.next milestone Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants