Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aii-ks: generate kickstart repo entries based on SPMA configuration #316

Merged
merged 19 commits into from
Dec 23, 2022
Merged

aii-ks: generate kickstart repo entries based on SPMA configuration #316

merged 19 commits into from
Dec 23, 2022

Conversation

stdweird
Copy link
Member

@stdweird stdweird commented Nov 18, 2019 •
edited
Loading

Based on #280 and #314 (and gombasg#1) and requires #315

@stdweird stdweird force-pushed the new_rhel8 branch 2 times, most recently from bf19f2b to d98ac1f Compare November 22, 2019 05:59
@jrha jrha added this to the 19.12 milestone Dec 5, 2019
@jrha jrha requested a review from gombasg December 11, 2019 13:16
jrha
jrha previously approved these changes Dec 11, 2019
View reviewed changes
Copy link
Member

@jrha jrha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @gombasg?

gombasg
gombasg reviewed Dec 12, 2019
View reviewed changes
@jrha jrha modified the milestones: 19.12, 20.2 Dec 20, 2019
@jrha
Copy link
Member

jrha commented Dec 20, 2019

Bumping to allow time for discussion.

@jrha jrha modified the milestones: 20.3, 20.4 Mar 19, 2020
@stdweird
Copy link
Member Author

stdweird commented Aug 7, 2020

@gombasg @jrha i'm pushing new functionality/behaviour to this PR

@stdweird
Copy link
Member Author

stdweird commented Aug 7, 2020

@gombasg @jrha @ned21 this is potentially backwards incompatible by handling the disabled_repos differently and more important any other code that uses the aii yum.repo file.

@ned21
Copy link
Contributor

ned21 commented Aug 16, 2020

Commits c180663 and fca0ace seem to have a corrupted commit log? I think @gombasg's comment about kernel debug packages needs to be addressed too?

@stdweird stdweird force-pushed the new_rhel8 branch 2 times, most recently from 4beea71 to 1a4e473 Compare August 19, 2020 20:49
@stdweird
Copy link
Member Author

@ned21 i forgot to squash those 2 commits in previous ones.
the debug remark of @gombasg is now solved by passing the disallowed/ignored package globs also to the yum install command in post.

@stdweird stdweird mentioned this pull request Aug 19, 2020
Closed
@ned21
Copy link
Contributor

ned21 commented Aug 22, 2020

Thanks for the update with rebase. I am not familiar with this code at all so will let someone else do the review.

@stdweird stdweird mentioned this pull request Mar 21, 2021
Open
@jrha jrha modified the milestones: 21.8, 21.6 May 4, 2021
@jrha
Copy link
Member

jrha commented May 4, 2021

@hpcugentbot test this please

stdweird added 17 commits July 1, 2021 15:57
@stdweird
ks: ksuserhooks: set active config before running the hook method
963ac1f
@stdweird
aii-ks: fix some more regex tests after new nmc-lib-blockdevices
f1f22a1
@stdweird
aii-ks: factor out proxy url modification
e685e9c
@stdweird
aii-ks: factor out repository proxy and baseurl modification
57279c4
@stdweird
aii-ks: generate the kickstart repo command from the SPMA repository …
7fa0409 
…configuration
@stdweird
aii-ks: do not install kernel debug rpms in post
111240b
@stdweird
aii-pxelinux: fix panlint line too long in schema
9b486e1
@stdweird
aii-ks: switch to globs for repository selection and some more code c…
db9578a 
…leanup
@stdweird
aii-ks: allow finegrained enable/disable/ignore control when generati…
1f0788f 
…ng the AII (post and post-reboot) repo configuration
@stdweird
aii-ks: generalise the glob pattern used by repo selection and also e…
669c13e 
…nable it for installtype
@stdweird
aii-pxelinux: fix bug when calling _kernel_params with correct varian…
b1b6c25 
…t in _write_grub2_config
@stdweird
aii-pxelinux: add globbing to the pxelinux initrd and kernel paths
2da99b8
@stdweird
aii-ks: handle disabled/ignored packages in post too
3928f1c
@stdweird
aii-ks: add boolean to control installation of (exact) kernel package…
eb9c80a 
…s in post
@stdweird
aii-ks: only root access to /tmp yum and log files
a5733f0
@stdweird
aii-pxelinux: Fix UEFI boot over http
e0bf6b6
@stdweird
pxelinux: support hostname lookup for EFI
b31044b
@jrha jrha modified the milestones: 21.12, 22.2 Dec 17, 2021
@stdweird stdweird mentioned this pull request Mar 10, 2022
Merged
jrha
jrha approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@jrha jrha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT

@jrha jrha merged commit a0f4585 into quattor:master Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gombasg gombasg gombasg left review comments

@jrha jrha jrha approved these changes

Assignees
No one assigned
Labels
backwards incompatible
Milestone
23.6
Development

Successfully merging this pull request may close these issues.
4 participants
@stdweird @jrha @ned21 @gombasg