-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Quarkus platform BOM version info collection for analytics #45487
Fix Quarkus platform BOM version info collection for analytics #45487
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and thanks for the fix @aloubyansky.
@brunobat about CUSTOM
value of the version - will the version reports need to be adjusted to accommodate this addition or it will be transparent to them?
I didn't start a separate discussion about this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think CUSTOM is fine and will show up in the versions on future reports.
This change must not be back-ported because it will pollute previous data in the system, @gsmet, @aloubyansky
I'm not sure I understand? For me, it's just make the reporting a bit more accurate but shouldn't pollute anything? Could you clarify? |
Yeah, I am not sure about the risk of backporting. But if you don't like the |
Because data for existing back-ported versions will have a mix of N/A and CUSTOM that will clash with the previous logic of only having N/A, especially if we look to major.minor versions. |
I like the CUSTOM, and it can be on a different PR. |
Just to clarify, @brunobat you would like me to remove the |
Yes, that way we can back-port the remaining changes without any concerns. |
…rties artifact is met first
8c986a6
to
3e7ebdf
Compare
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! Thanks @aloubyansky
Status for workflow
|
Pixes platform BOM info collection processing project's dependency version constraints