Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override defaults from build time that also apply to runtime #45431

Merged

Conversation

radcortez
Copy link
Member

@radcortez radcortez commented Jan 7, 2025

When a default value can be set for both build time and runtime (for instance, logging), the build time default takes priority over RunTimeConfigurationDefaultBuildItem. The build item should have priority in this case.

Related conversation:
https://quarkusio.zulipchat.com/#narrow/channel/187038-dev/topic/RunTimeConfigurationDefaultBuildItem.20VS.20.40WithDefault

This comment has been minimized.

@radcortez radcortez force-pushed the override-build-defaults-in-runtime branch from 22e9b33 to 81cd3dc Compare January 8, 2025 11:11
@geoand geoand requested a review from mkouba January 8, 2025 12:41
Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This comment has been minimized.

@gsmet gsmet force-pushed the override-build-defaults-in-runtime branch from 81cd3dc to 64573d5 Compare January 9, 2025 09:14

This comment has been minimized.

@radcortez radcortez force-pushed the override-build-defaults-in-runtime branch from 64573d5 to 39f4086 Compare January 9, 2025 20:46
Copy link

quarkus-bot bot commented Jan 10, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 39f4086.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17 Windows

📦 integration-tests/opentelemetry-quickstart

io.quarkus.it.opentelemetry.OpenTelemetryDisabledTest.buildTimeDisabled - History

  • Condition with Lambda expression in io.quarkus.it.opentelemetry.OpenTelemetryDisabledTest was not fulfilled within 200 milliseconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.OpenTelemetryDisabledTest was not fulfilled within 200 milliseconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.it.opentelemetry.OpenTelemetryDisabledTest.buildTimeDisabled(OpenTelemetryDisabledTest.java:29)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

@radcortez radcortez merged commit 7776023 into quarkusio:main Jan 10, 2025
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants