Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issues#976] Fix api.qute condition to include jakarta constraint annotations to all endpoint parameters #978

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

JPSantistebanQ
Copy link
Contributor

Fixed #976

This PR fixes a condition in the api.qute template that was making the generated endpoint parameters not include the jakarta constrain annotations when use-bean-validation was true.

Many thanks for submitting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Your code is properly formatted according to our code style
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Subject
  • Pull Request contains link to the issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-quarkus2 to backport the original PR to the quarkus2 branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@JPSantistebanQ JPSantistebanQ requested a review from a team as a code owner February 3, 2025 04:09
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@mcruzdev mcruzdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wooow, nice!

@hbelmiro hbelmiro merged commit 2eabcb2 into quarkiverse:main Feb 4, 2025
9 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 4, 2025
…nnotations to all endpoint parameters (#978)

* [issues#964] Fix beanValidationCore.qute condition to include the jakarta.validation.Valid annotation

* [issues#976] Fix api.qute condition to include constraint annotations to all endpoint params
@hbelmiro
Copy link
Contributor

hbelmiro commented Feb 4, 2025

@all-contributors add @JPSantistebanQ for code and tests.

Copy link
Contributor

@hbelmiro

I've put up a pull request to add @JPSantistebanQ! 🎉

hbelmiro pushed a commit that referenced this pull request Feb 4, 2025
…nnotations to all endpoint parameters (#978) (#980)

* [issues#964] Fix beanValidationCore.qute condition to include the jakarta.validation.Valid annotation

* [issues#976] Fix api.qute condition to include constraint annotations to all endpoint params

Co-authored-by: Juan Piero Santisteban Quiroz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing annotations @NotNull @Patters, @Size ... to all PathParams, HeaderParams
4 participants