-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[issues#976] Fix api.qute
condition to include jakarta constraint annotations to all endpoint parameters
#978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arta.validation.Valid annotation
… to all endpoint params
ricardozanini
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
mcruzdev
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wooow, nice!
hbelmiro
approved these changes
Feb 4, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Feb 4, 2025
…nnotations to all endpoint parameters (#978) * [issues#964] Fix beanValidationCore.qute condition to include the jakarta.validation.Valid annotation * [issues#976] Fix api.qute condition to include constraint annotations to all endpoint params
7 tasks
@all-contributors add @JPSantistebanQ for code and tests. |
I've put up a pull request to add @JPSantistebanQ! 🎉 |
hbelmiro
pushed a commit
that referenced
this pull request
Feb 4, 2025
…nnotations to all endpoint parameters (#978) (#980) * [issues#964] Fix beanValidationCore.qute condition to include the jakarta.validation.Valid annotation * [issues#976] Fix api.qute condition to include constraint annotations to all endpoint params Co-authored-by: Juan Piero Santisteban Quiroz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #976
This PR fixes a condition in the
api.qute
template that was making the generated endpoint parameters not include the jakarta constrain annotations when use-bean-validation was true.Many thanks for submitting your Pull Request ❤️!
Please make sure that your PR meets the following requirements:
[0.9.x] Subject
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>
, where<branch-name>
is the name of the branch where the pull request must be backported to (e.g.,backport-quarkus2
to backport the original PR to thequarkus2
branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.