Fix #1022 - Discriminator should only add Jackson JsonSubTypes when there's a parent class

[ricardozanini]

Fix #1022

Many thanks for submitting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

• You have read the contributors guide
• Your code is properly formatted according to our code style
• Pull Request title contains the target branch if not targeting main: [0.9.x] Subject
• Pull Request contains link to the issue
• Pull Request contains link to any dependent or related Pull Request
• Pull Request contains description of the issue
• Pull Request does not include fixes for issues other than the main ticket

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-quarkus2 to backport the original PR to the quarkus2 branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

[ricardozanini]

@pefernan @fjtirado we will need to upgrade Kogito to reflect this fix.

[pefernan]

@ricardozanini aside from the version upgrade will it require any change in the codebase?

[fjtirado]

@ricardozanini aside from the version upgrade will it require any change in the codebase?

@pefernan I do not think this affecting kogito codebase. The generated code basically assumes that the provided arguments can be converted to the POJO associated to the operation. Obviously, when we upgrade the release, a spec with that structure should work. Im assuming now is probably not (because the converstion from Json to POJO will fail)

[hbelmiro]

@ricardozanini @fjtirado, can one of you cherry-pick it for the main-lts branch please?
To avoid doing it manually in the future, you can add the backport-main-lts label before merging it.

[ricardozanini]

This one supposedly not to be merged before approvals. I'll do it manually since we need the lts. @pefernan fyi

[ricardozanini]

@ricardozanini aside from the version upgrade will it require any change in the codebase?

No changes in the codebase. The problem is that some specs now won't work in runtime because if this bug.