Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI - run the pytest-numpy-2 job also with Python 3.13 #6974

Merged

Conversation

pavoljuhas
Copy link
Collaborator

The pytest-numpy-2 job excludes cirq-rigetti which is not yet compatible with
Python 3.13. This activates Python 3.13 testing for other Cirq packages.

Related to #6932

This CI job excludes cirq-rigetti which is not yet compatible with
Python 3.13.  This activates Python 3.13 testing for other Cirq packages.

Related to quantumlib#6932
@pavoljuhas pavoljuhas requested review from vtomole and a team as code owners January 24, 2025 19:53
@pavoljuhas pavoljuhas requested a review from dabacon January 24, 2025 19:53
@CirqBot CirqBot added the Size: XS <10 lines changed label Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.88%. Comparing base (0f21e0a) to head (2e19d8b).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6974      +/-   ##
==========================================
- Coverage   97.88%   97.88%   -0.01%     
==========================================
  Files        1085     1085              
  Lines       94991    94992       +1     
==========================================
- Hits        92983    92982       -1     
- Misses       2008     2010       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pavoljuhas pavoljuhas marked this pull request as draft January 24, 2025 20:14
In Python 3.13 `Mock(EngineClient)` creates an AsyncMock for
`EngineClient.get_processor()`.  Here we adjust the class
mocking so it works for both Python 3.12 and 3.13.
@CirqBot CirqBot added the size: S 10< lines changed <50 label Jan 25, 2025
@pavoljuhas pavoljuhas marked this pull request as ready for review January 25, 2025 07:34
@pavoljuhas pavoljuhas requested a review from mhucka January 27, 2025 19:41
Copy link
Contributor

@mhucka mhucka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavoljuhas pavoljuhas added this pull request to the merge queue Jan 28, 2025
Merged via the queue into quantumlib:main with commit ab62c25 Jan 28, 2025
38 checks passed
@pavoljuhas pavoljuhas deleted the ci-test-numpy-2-with-python-3.13 branch January 28, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: S 10< lines changed <50 Size: XS <10 lines changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants