Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compatible 2.6.2 #2

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Make compatible 2.6.2 #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3fcaf6f
compatibilityg
znewsham Sep 29, 2022
4ae975a
readd dynamic
znewsham Sep 29, 2022
ba2fb7c
latest
znewsham Oct 12, 2022
7982108
support esbuild dynamic imports
znewsham Dec 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/blaze-tools/preamble.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import {
parseStringLiteral
} from './tokens';

BlazeTools = {
export const BlazeTools = {
EmitCode,
toJSLiteral,
toObjectLiteralKey,
Expand All @@ -25,5 +25,3 @@ BlazeTools = {
parseExtendedIdentifierName,
parseStringLiteral
};

export { BlazeTools };
7 changes: 7 additions & 0 deletions packages/blaze/dombackend.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
// this is necessary because when esbuild chunks things (when using dynamic imports)
// it assumes that every import in that chunk is independent of each other (which is technically correct)
// however, because blaze has an implicit depedency that jquery loads first, this fails.
// this could be fixed more correctly by changing how we generate dependencies.js - but it would be brutal
// it would require that every import be alone in a file with an import to it's predecessor
import "meteor/jquery";

var DOMBackend = {};
Blaze._DOMBackend = DOMBackend;

Expand Down
2 changes: 1 addition & 1 deletion packages/html-tools/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { Scanner } from './scanner';
import { parseFragment, codePointToString, getContent, getRCData } from './parse';
import { getComment, getDoctype, getHTMLToken, getTagToken, TEMPLATE_TAG_POSITION } from './tokenize';

HTMLTools = {
const HTMLTools = {
asciiLowerCase,
properCaseTagName,
properCaseAttributeName,
Expand Down
2 changes: 1 addition & 1 deletion packages/observe-sequence/observe_sequence.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const has = function (obj, key) {
return !!obj && (
keyParts.length > 1
? has(obj[key.split('.')[0]], keyParts.slice(1).join('.'))
: hasOwnProperty.call(obj, key)
: Object.hasOwnProperty.call(obj, key)
);
};

Expand Down
4 changes: 1 addition & 3 deletions packages/spacebars-compiler/preamble.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { optimize } from './optimizer';
import { parse, compile, codeGen, TemplateTagReplacer, beautify } from './compiler';
import { TemplateTag } from './templatetag';

SpacebarsCompiler = {
export const SpacebarsCompiler = {
CodeGen,
_builtInBlockHelpers: builtInBlockHelpers,
isReservedName,
Expand All @@ -15,5 +15,3 @@ SpacebarsCompiler = {
_beautify: beautify,
TemplateTag,
};

export { SpacebarsCompiler };