Merge pull request #18 from SupercedeTech/review-comments

Review comments
qrilka · Dec 8, 2021 · 180cae3 · 180cae3
2 parents 72aac52 + 4e84995
commit 180cae3
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 10 deletions.
diff --git a/src/Codec/Xlsx/Writer/Stream.hs b/src/Codec/Xlsx/Writer/Stream.hs
@@ -133,7 +133,7 @@ defaultSettings = MkSheetWriteSettings
 --  the others are exposed in case you can cache the shared strings for example.
 --
 --  Note that the current implementation concatenates everything into a single sheet.
---  In other words there is no tab support yet.
+--  In other words there is no support for writing multiple sheets
 writeXlsx :: MonadThrow m
     => PrimMonad m
     => SheetWriteSettings -- ^ use 'defaultSettings'
@@ -274,7 +274,6 @@ sheetViews = do
     let
         view' :: [Element]
         view' = setNameSpaceRec spreadSheetNS . toXMLElement .  toElement (n_ "sheetView") <$> sheetView
-    -- tag (n_ "sheetView") (attr "topLeftCell" "D10" <> attr "tabSelected" "1") $ pure ()
 
     C.yieldMany $ elementToEvents =<< view'
 

diff --git a/test/Main.hs b/test/Main.hs
@@ -1,8 +1,5 @@
--- {-# OPTIONS_GHC -F -pgmF tasty-discover #-}
 {-# LANGUAGE OverloadedLists   #-}
 {-# LANGUAGE OverloadedStrings #-}
-{-# LANGUAGE QuasiQuotes       #-}
-{-# LANGUAGE RecordWildCards   #-}
 module Main
   ( main
   ) where

diff --git a/xlsx.cabal b/xlsx.cabal
@@ -36,7 +36,6 @@ Flag microlens
 
 Library
   Hs-source-dirs:    src
-  profiling: False
   ghc-options:       -Wall
   Exposed-modules:   Codec.Xlsx
                    , Codec.Xlsx.Types
@@ -87,7 +86,6 @@ Library
   Other-modules:     Codec.Xlsx.Parser.Stream.HexpatInternal
 
   Build-depends:     base         >= 4.9.0.0 && < 5.0
-                   , async
                    , attoparsec
                    , base64-bytestring
                    , binary-search
@@ -101,7 +99,6 @@ Library
                    , extra
                    , filepath
                    , hexpat
-                   , List
                    , mtl          >= 2.1
                    , network-uri
                    , old-locale   >= 1.0.0.5
@@ -118,8 +115,6 @@ Library
                    , zip-stream   >= 0.2.0.1
                    , xml-types
                    , exceptions
-                   , lifted-async
-                   , stm
                    , transformers-base
                    , monad-control
   if flag(microlens)