-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to build system and removing deprecated functions #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
phoebe-p
commented
Jun 27, 2024
•
edited
Loading
edited
- Fixed deprecated Numpy functions
- Changes testing workflow to remove old Python versions (now testing 3.9 - 3.12)
- Update Github actions versions
- Use a specific version of spin (0.9) which does not cause issues with the --ignore flag for including test_examples.py
- remove S4 installation for MacOS ARM/M1, since this no longer works for some reason (complaining about not finding boost header files even when homebrew path is explicitly linked in Makefile.m1)
- Changes to phoebe-p/S4 to stop compiler errors with Interpolator type
- Increase relative allowed error in approximate comparisons for tests
…ficient to be set by user
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #278 +/- ##
========================================
Coverage 60.23% 60.24%
========================================
Files 108 108
Lines 12361 12358 -3
========================================
- Hits 7446 7445 -1
+ Misses 4915 4913 -2 ☔ View full report in Codecov by Sentry. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.