Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to build system and removing deprecated functions #278

Merged
merged 46 commits into from
Jun 27, 2024
Merged

Conversation

phoebe-p
Copy link
Member

@phoebe-p phoebe-p commented Jun 27, 2024

  • Fixed deprecated Numpy functions
  • Changes testing workflow to remove old Python versions (now testing 3.9 - 3.12)
  • Update Github actions versions
  • Use a specific version of spin (0.9) which does not cause issues with the --ignore flag for including test_examples.py
  • remove S4 installation for MacOS ARM/M1, since this no longer works for some reason (complaining about not finding boost header files even when homebrew path is explicitly linked in Makefile.m1)
  • Changes to phoebe-p/S4 to stop compiler errors with Interpolator type
  • Increase relative allowed error in approximate comparisons for tests

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.24%. Comparing base (7765b27) to head (3f940e3).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #278   +/-   ##
========================================
  Coverage    60.23%   60.24%           
========================================
  Files          108      108           
  Lines        12361    12358    -3     
========================================
- Hits          7446     7445    -1     
+ Misses        4915     4913    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phoebe-p phoebe-p merged commit a2eefa9 into develop Jun 27, 2024
58 of 59 checks passed
@phoebe-p phoebe-p mentioned this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant