Deploy wheels to PyPI when pushing tags #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some tests are failing, which is odd because I haven't changed a comma in any file other than the deploy workflow one... |
Codecov Report
@@ Coverage Diff @@
## develop #248 +/- ##
========================================
Coverage 57.12% 57.12%
========================================
Files 103 103
Lines 11621 11621
========================================
Hits 6639 6639
Misses 4982 4982 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Don’t worry about the failing tests, it happens sometimes randomly with the scheduled testing as well. I mean, this is quite worrying in itself, but it is not caused by these changes… |
phoebe-p
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current deploy workflow was obsolete and it was not being triggered when pushing tags to the repo, which is precisely the condition required to trigger the upload. So, it was an impossible situation.
This PR adds pushing tags as a trigger of the workflow and separates the publishing step as a separate job, using
download-artefactandgh-action-pypi-publishactions to make the process more robust.