Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] RCWA test are skipped if S4 not intalled #244

Merged
merged 2 commits into from
Feb 13, 2023

Conversation

Abelarm
Copy link
Contributor

@Abelarm Abelarm commented Feb 11, 2023

Solving the issue #241.

Create a function in conftest.py probably not the cleanest place, should go inside something like test/utils but don't know if there will be more function inside 🤷‍♂️

Tested:
image

@Abelarm Abelarm changed the title [ENH] RCWA test are skipped in S4 not intalled [ENH] RCWA test are skipped if S4 not intalled Feb 11, 2023
@codecov
Copy link

codecov bot commented Feb 11, 2023

Codecov Report

Merging #244 (9447279) into develop (fb8deab) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #244   +/-   ##
========================================
  Coverage    57.10%   57.11%           
========================================
  Files          103      103           
  Lines        11615    11621    +6     
========================================
+ Hits          6633     6637    +4     
- Misses        4982     4984    +2     
Impacted Files Coverage Δ
solcore/tests/test_depletion_approximation.py 99.45% <0.00%> (-0.28%) ⬇️
solcore/tests/conftest.py 93.04% <0.00%> (+0.38%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@phoebe-p phoebe-p merged commit 277728b into qpv-research-group:develop Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants