-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Move to meson build system #242
Merged
phoebe-p
merged 67 commits into
qpv-research-group:develop
from
Abelarm:meson_build_system
Feb 2, 2023
Merged
[ENH] Move to meson build system #242
phoebe-p
merged 67 commits into
qpv-research-group:develop
from
Abelarm:meson_build_system
Feb 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d a new workflow in git to check the meson build
Examples in windows took more than 3 hours.
… meson_build_system
Codecov Report
@@ Coverage Diff @@
## develop #242 +/- ##
============================================
+ Coverage 46.15% 57.10% +10.95%
============================================
Files 85 103 +18
Lines 9124 11615 +2491
============================================
+ Hits 4211 6633 +2422
- Misses 4913 4982 +69
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hi both, sorry I missed the review request for this PR. I will quickly check tomorrow when I have my Windows laptop if the Windows wheel also works and then merge! Edit: it works :) this is great!!! |
phoebe-p
approved these changes
Feb 2, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refer to the issue #238 ad it changes the build system from
numpy.distutils
tomeson
.command to build:
with_pdd=true
: if to build thepdd
install_test=true
: if to copy the test directoryMajor changes:
poisson_drift_diffusion
fortran codesetup.py
moving topyproject.toml
devpy
as a support build toolmac-os arm64
now available through cross-compiling with the support ofpdd
cibuildwheel
for the whole build process (common to all architectures)Minor changes:
macos
test now install S4 as welltest-optics
now skipped for windowsnumpy
TESTED WHEELS:
LINK to wheels
Know issues:
meson.build
fileflake8
does not support nativelypyproject.toml
Solution; use a alias
Flake8-pyproject
TODO (after consensus):
setup.cfg
mypy.ini
to be integrated inpyproject.toml
windows
andmacos - arm64
test_examples
does not work onwindows