Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS paper review (1) #33

Merged
merged 28 commits into from
Aug 10, 2021
Merged

JOSS paper review (1) #33

merged 28 commits into from
Aug 10, 2021

Conversation

phoebe-p
Copy link
Member

Addresses #29, #30, #31 (partially) and adds/fixes license and copyright information.

@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #33 (4f509f4) into devel (ade160e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            devel      #33   +/-   ##
=======================================
  Coverage   90.63%   90.63%           
=======================================
  Files          20       20           
  Lines        2316     2316           
=======================================
  Hits         2099     2099           
  Misses        217      217           
Impacted Files Coverage Δ
rayflare/analytic/diffraction.py 65.07% <ø> (ø)
rayflare/angles.py 50.87% <ø> (ø)
rayflare/matrix_formalism/ideal_cases.py 95.83% <ø> (ø)
rayflare/matrix_formalism/multiply_matrices.py 97.31% <ø> (ø)
rayflare/matrix_formalism/process_structure.py 96.90% <ø> (ø)
rayflare/options.py 100.00% <ø> (ø)
rayflare/ray_tracing/rt.py 88.74% <ø> (ø)
rayflare/rigorous_coupled_wave_analysis/rcwa.py 90.33% <ø> (ø)
rayflare/state.py 75.00% <ø> (ø)
rayflare/structure.py 87.50% <ø> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ade160e...4f509f4. Read the comment docs.

@phoebe-p phoebe-p merged commit 0fd0451 into devel Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant