Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

572 join error #670

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

572 join error #670

wants to merge 14 commits into from
+53 −27

Conversation

idruzhitskiy
Copy link
Contributor

Closes #572

@ikopylov
Copy link
Member

I searched for information about the cancelled error. There are comments in several places where it is indicated that there is a possibility that there will be a cancellation error when the runtime is stopped. Comments are here:

  1. Observability of JoinError::Cancelled tokio-rs/tokio#2077 (comment)
  2. https://users.rust-lang.org/t/can-this-tokio-task-get-canceled-if-i-await-its-handle/88203/4

So, unfortunately, we should handle cancelled error in a special way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikopylov ikopylov ikopylov left review comments

Assignees
No one assigned
Labels
required for release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Question: best JoinError handling
2 participants
@idruzhitskiy @ikopylov