Skip to content

Commit

Permalink
851 ci update alien test to capture the problem with lost records (#853)
Browse files Browse the repository at this point in the history
* change writing logic for test

* update changelog

* Update CHANGELOG.md
  • Loading branch information
Ziktorin authored Dec 29, 2023
1 parent 2d5f091 commit 519c950
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ Bob versions changelog
- Record timestamp is now passed to Pearl level and used to find newest record in get and exist functions (#708)
- Save gRPC error when parsing status (#842)
- Increased number and max delay of retries for Bob state checking in integration tests (#856)
- Update writing logic for aliens integration tests to capture lost records problem (#851)

#### Fixed
- Fix missing alien records due to multiple groups (#806)
Expand Down
8 changes: 5 additions & 3 deletions integration-tests/tests_aliens.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,10 @@ def run_tests(behaviour, args):
#runs put and stops nodes in cycle
written_count = 0
try:
for i in range(1, parsed_args.nodes_amount + 1):
#make correctly formatted args
for i in range(parsed_args.nodes_amount):
#make correctly formatted args
dict_args = make_run_args(parsed_args, written_count, record_amount)
dict_args['-p'] = str(parsed_args.transport_min_port + i)
bobp_args = args_to_str(dict_args)
#run put
print(f'Running bobp -b put {bobp_args.rstrip()}')
Expand All @@ -91,7 +92,7 @@ def run_tests(behaviour, args):
if not 'total err: 0' in str(p):
print_then_exit(f'Put test failed, see output.')
written_count += dict_args.get('-c')
if i < parsed_args.nodes_amount:
if i < parsed_args.nodes_amount - 1:
#stops one
sleep(10)
d_cli.container.stop(container_dict[str(parsed_args.transport_min_port + i)])
Expand Down Expand Up @@ -119,6 +120,7 @@ def run_tests(behaviour, args):


dict_args = make_run_args(parsed_args, 0, str(written_count))
dict_args['-p'] = str(parsed_args.transport_min_port + parsed_args.nodes_amount - 1)
bobp_args = args_to_str(dict_args)
for item in run_options:
run_tests(item, bobp_args)

0 comments on commit 519c950

Please sign in to comment.