refactor: migrate test app package to TypeScript #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelegera
force-pushed
the
test-app-typescript-conversion
branch
3 times, most recently
from
b720e01 to
4758c50
Compare
michelegera
force-pushed
the
test-app-typescript-conversion
branch
3 times, most recently
from
50151fb to
34f7d3b
Compare
vscav
reviewed
Nov 27, 2023
|
We also need to update the CI script to take into account the test-app when running the type-checking with different TS versions. You can have a look on |
vscav
changed the title
michelegera
force-pushed
the
test-app-typescript-conversion
branch
from
34f7d3b to
b78a662
Compare
michelegera
force-pushed
the
test-app-typescript-conversion
branch
from
b78a662 to
2413ab0
Compare
|
@vscav Thanks for the review. This commit adds type-checking with different TS versions for I’ve also added a comment to explain why we use |
vscav
reviewed
Nov 27, 2023
michelegera
force-pushed
the
test-app-typescript-conversion
branch
from
2413ab0 to
7647e76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the
test-appapplication to TypeScript and completes the migration started with #116.