Realign #2
Merged
Realign #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated composer.json
- Deprecated: apcu_store(): Passing null to parameter #3 ($ttl) of type int is deprecated
…pects exactly 0 arguments, 1 given - Delete unrable statements
…essfully. As part of accomplishing this, the following was done: - Added "yoast/phpunit-polyfills" as a dev dependency. - Modified fixtures to use the polyfilled methods (as they are cross version compatible). - Added a custom test runner (that is compatible across PHPUnit versions). - Modified PHPUnit version to be "^7|^8|^9", since each is supported by different PHP versions. - Modified the rector version to "^0.12.19", as that is the last one still supporting PHP 7.1. - Changed expectNotice() and expectError() to expecting the equivalent PHPUnit exception, to avoid deprecation notice and support PHPUnit 7, where this feature is absent. - Removed the requires annotation in Zend_Filter_Encrypt_OpensslTest - Explicitly added "RC4" as the value for the algo to appease supported PHP versions. Why RC4? Because that is the default, and has been the default, and ZF has had no option to override it. Such option could be introduced in a separate PR maybe. - Fixed a type related warning in OpenSSL related tests, by casting array keys to strings before the remaining checks that assume a string. - Added an openssl.conf file that enables the legacy provider, in addition to the default, in order to enable the tests to pass in newer OpenSSL versions that even older PHP versions are now being compiled against. Also provided higher test coverage overall. To accomplish that part: - Added "symfony/polyfill-ctype" as a runtime dependency, as it can be disabled (while the test tooling does not require it), but is required by many components. - Made PHPUnit run twice - once with the bare minimum of extensions needed to get it going, and a second time with all extensions that can be enabled for the given PHP version. Zend_Barcode_AllTests in particular benefits of this, as it has both tests that work only if GD is disabled, as well as tests that run only if GD is enabled. - Moved the PHP extensions from the env into a matrix, and adjusted the set of extensions to be one that the PHP version would support. - Adjusted the JSON encoder and decoder to explicitly use "UTF-16BE" instead of just "UTF-16", as the mbstring polyfill uses iconv, which in turn aliases "UTF-16" to "UTF-16LE", while the true mbstring extension aliases "UTF-16" to "UTF-16BE". The explicit notation works with both. - Adjusted the testDisablingTryCommonMagicFilesIgnoresCommonLocations() test to call setMagicFile(false) when the environment is not good, i.e. when fileinfo is not present. - Added some requires annotations where PDO was assumed to be present.
PHP Deprecated: urlencode(): Passing null to parameter #1 ($string) of type string is deprecated in Zend/Controller/Router/Route/Module.php on line 264
isNumber() bugfix
PHP8.2 - Fix null beeing passed to urlencode
Basic Sendgrid Transport Class
Fix/cache apcu update
Fix PHPDoc for @methods to ensure static analysers understand it
Avoid undefined array key access inside url assembly
…proto Support X-Forwarded-Proto header
…cale add "array" as allowed type of $value
…($string) must be of type string, array given in ... /Zend/Http/Client/Adapter/Socket.php:362
Updated DocBlocks to return `$this` for fluent interface
Fixes `A non-numeric value encountered` in PhpMath.php
Improving limit method using OVER()
Zend_Http_Client-Adapter_Socket - check transfer-encoding header is a string (and not an array)
1.24.0 release
Fixes deprecation message when running on php8 `Deprecated: realpath(): Passing null to parameter #1 ($path) of type string is deprecated i`
…biguityIdentity is TRUE Previously, _authenticateValidateResult expected a valid identity record to be passed as an argument, leading to an error when AmbiguityIdentity is TRUE but no matching identity records were found. Now, it gracefully handles the condition and sends the same failure message that _authenticateValidateResultSet sends when no matching records are found.
…r-large-text Fix for very slow chunk processing for larger content in the http res…
Add check in DbTable Authentication Adapter for empty results when AmbiguityIdentity is TRUE
Fix deprecation message in php8 with null param with realpath()
…tions Fix deprecated usage of string functions in `BaseUrl` helper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.