-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop python 3.8 support and add python 3.12 tests #639
base: main
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 13303486619Details
💛 - Coveralls |
Thanks @t-imamichi! This PR looks good to me. |
Added a release note |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
LGTM! |
We need to drop 3.8 support soon because aer did it for 0.16.1 Qiskit/qiskit-aer#2287 |
…t the latest scipy 0.15
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me. The tox.ini py313 test env, I guess it doesn't hurt, just seems a bit counter to the max of 3.12.
Of course the Branch Rules will need updating to match these changes.
Summary
Addresses #638
qiskit-machine-learning also dropped the support of Python 3.8 already.
qiskit-community/qiskit-machine-learning#826
This adds tests of python 3.12 for Linux and Windows because the latest CPLEX provides wheels for the platforms.
Note that CPLEX does not provide a wheel for Python 3.12 on macOS.
This also simplifies gurobipy constraints because gurobipy provides arm64 wheels.
Details and comments