Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 3.8 support and add python 3.12 tests #639

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

t-imamichi
Copy link
Collaborator

@t-imamichi t-imamichi commented Oct 17, 2024

Summary

Addresses #638

qiskit-machine-learning also dropped the support of Python 3.8 already.
qiskit-community/qiskit-machine-learning#826

This adds tests of python 3.12 for Linux and Windows because the latest CPLEX provides wheels for the platforms.
Note that CPLEX does not provide a wheel for Python 3.12 on macOS.

This also simplifies gurobipy constraints because gurobipy provides arm64 wheels.

Details and comments

@t-imamichi t-imamichi changed the title Bump minimum supported python version to 3.9 (WIP) Bump minimum supported python version to 3.9 Oct 17, 2024
@t-imamichi t-imamichi changed the title (WIP) Bump minimum supported python version to 3.9 (WIP) Drop python 3.8 support Oct 18, 2024
@coveralls
Copy link

coveralls commented Oct 25, 2024

Pull Request Test Coverage Report for Build 13303486619

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 92.104%

Totals Coverage Status
Change from base Build 13105033536: 0.05%
Covered Lines: 5681
Relevant Lines: 6168

💛 - Coveralls

TolisChal
TolisChal previously approved these changes Nov 6, 2024
@TolisChal
Copy link
Collaborator

Thanks @t-imamichi! This PR looks good to me.

@t-imamichi t-imamichi changed the title (WIP) Drop python 3.8 support Drop python 3.8 support Nov 25, 2024
@t-imamichi t-imamichi marked this pull request as ready for review November 25, 2024 09:42
@t-imamichi
Copy link
Collaborator Author

Added a release note

Dniskk
Dniskk previously approved these changes Nov 26, 2024
Copy link
Collaborator

@Dniskk Dniskk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

TolisChal
TolisChal previously approved these changes Dec 16, 2024
@TolisChal
Copy link
Collaborator

LGTM!

@t-imamichi t-imamichi dismissed stale reviews from TolisChal and Dniskk via a577508 January 14, 2025 03:10
@t-imamichi
Copy link
Collaborator Author

We need to drop 3.8 support soon because aer did it for 0.16.1 Qiskit/qiskit-aer#2287

@t-imamichi t-imamichi changed the title Drop python 3.8 support Drop python 3.8 support and add python 3.12 support Feb 13, 2025
@t-imamichi t-imamichi changed the title Drop python 3.8 support and add python 3.12 support Drop python 3.8 support and add python 3.12 tests Feb 13, 2025
Copy link
Member

@woodsp-ibm woodsp-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. The tox.ini py313 test env, I guess it doesn't hurt, just seems a bit counter to the max of 3.12.

Of course the Branch Rules will need updating to match these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants