[3D] Fix reset view button #60413
[3D] Fix reset view button #60413
Conversation
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
Tests failed for Qt 6One or more tests failed using the build from commit 8d3bb95 virtual_pointcloud_3d_overview (testPointCloud3DOverview)virtual_pointcloud_3d_overviewTest failed at testPointCloud3DOverview at tests/src/3d/testqgspointcloud3drendering.cpp:603
The full test report (included comparison of rendered vs expected images) can be found here. Further documentation on the QGIS test infrastructure can be found in the Developer's Guide. |
Tests failed for Qt 5One or more tests failed using the build from commit 3455251 virtual_pointcloud_3d_overview (testPointCloud3DOverview)virtual_pointcloud_3d_overviewTest failed at testPointCloud3DOverview at tests/src/3d/testqgspointcloud3drendering.cpp:603
The full test report (included comparison of rendered vs expected images) can be found here. Further documentation on the QGIS test infrastructure can be found in the Developer's Guide. |
Withalion
force-pushed
the
vpc-reset-view-fix
branch
from
7524667 to
fe4424e
Compare
|
|
Withalion
force-pushed
the
vpc-reset-view-fix
branch
from
b6d44f7 to
0995c8d
Compare
Withalion
changed the title
Withalion
force-pushed
the
vpc-reset-view-fix
branch
3 times, most recently
from
f4c943c to
7882f13
Compare
Withalion
force-pushed
the
vpc-reset-view-fix
branch
from
7882f13 to
5157acf
Compare
Withalion
force-pushed
the
vpc-reset-view-fix
branch
from
5157acf to
3729055
Compare
There was a problem hiding this comment.
clang tidy failed with https://github.com/qgis/QGIS/actions/runs/13661129187/job/38194953395?pr=60413#step:9:268
Object is unused and not unallocated
src/3d/qgscameracontroller.cpp
Outdated
| @@ -206,9 +208,9 @@ void QgsCameraController::setLookingAtPoint( const QgsVector3D &point, float dis | |||
| setCameraPose( camPose ); | |||
| } | |||
|
|
|||
| void QgsCameraController::setCameraPose( const QgsCameraPose &camPose ) | |||
| void QgsCameraController::setCameraPose( const QgsCameraPose &camPose, const bool force ) | |||
There was a problem hiding this comment.
you can remove the const: const QgsCameraPose &camPose, bool force
Withalion
force-pushed
the
vpc-reset-view-fix
branch
from
3729055 to
4e14214
Compare
|
@benoitdm-oslandia the clang tidy check is failing on precompiled headers, the stuff you mentioned is just warnings. Anyway the unalloceted memory I fixed, but the unused warning is a mistake by clang tidy as it is used few lines below creation... |
|
Apparently breaks the nightly https://cdash.orfeo-toolbox.org/viewBuildError.php?buildid=29235 |
|
@jef-n the issue was not introduced by this PR, but another one. Anyway the fix for that will come with fixes for other 3D point cloud editing tools related bugs. |
Description
This PR fixes reset view button giving wrong camera positions for virtual point clouds, and also fixes a bug where resetting view multiple times would set near & far planes incorrectly. Also it fixes initial position setting of camera after opening 3D view, which should be set to top down view of whole scene.