-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sip] Don't use deprecated annotation with message #60363
[Sip] Don't use deprecated annotation with message #60363
Conversation
It crashes in 6.9.1
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
Is the backport to release-3_40 actually needed? |
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-3_40 release-3_40
# Navigate to the new working tree
cd .worktrees/backport-release-3_40
# Create a new branch
git switch --create backport-60363-to-release-3_40
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 789f58439fbfe73c914bd12e4b0916fef0115d19
# Push it to GitHub
git push --set-upstream origin backport-60363-to-release-3_40
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-3_40 Then, create a pull request where the |
No you're right the feature was added after3.40 |
QGIS 3.41.0-Master from OSGeo4W on Windows 10 no longer crashes after this PR. Thanks! |
It crashes in 6.9.1, I'll restore it when everything is fixed. Reason of crash for context here
Fixes #60286