Use native raster API in QgsGridFileWriter #60320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if this should be backported. |
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
alexbruy
force-pushed
the
gridfilewriter-gdal
branch
from
1e76b8a to
9516a74
Compare
|
Thanks for taking care of this issue! I think it's actually a bug: the algorithms allow to specify any output layer format (e.g. GeoTIFF), however the content of the output file is incorrect since it is not in the specified layer format. So I think this fix should be backported. Alternatively, I think the algorithms' output layer parameter in the GUI should list the ASCII grid format only and the algorithm should emit an exception if called with a different output layer format. |
nyalldawson
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update
QgsGridFileWriterclass used to save interpiolation results to use QGIS raster API. This allows to save interpolation results into any GDAL-supported format, not only as ASCII grid.Fixes #56653.