Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg] Enable kea and freexl drivers for GDAL #60201

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Conversation

m-kuhn
Copy link
Member

@m-kuhn m-kuhn commented Jan 21, 2025

Because more drivers, more pleasure

Because more drivers, more pleasure
@github-actions github-actions bot added this to the 3.42.0 milestone Jan 21, 2025
Copy link

github-actions bot commented Jan 21, 2025

🧮 Vcpkg update report

Added packages:
🍓 kealib: 1.6.0 (Features: )

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit 735e4d9)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 735e4d9)

@@ -42,8 +42,9 @@
"expat",
{
"name": "gdal",
"default-features": false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see this! I was hesitating to propose this because I was not sure how works the default-feature/recommended-feature override here and there

Btw, Is this normal ?

So far, QGIS was not able to open Geopackage because sqlite was missing because of this line

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixed bag of questions:

  1. default-features were already enabled so far whenever built with bindings, because in the bindings dependency, default-features was not deactivated. This is not expected and actually the change that we want here.
  2. The decision what's a default feature for gdal is not taken in here, this is mostly a copy of the upstream gdal port with some adjustments for python. Let's not dive into technicalities how it's implemented.
  3. I would like to get rid of our gdal overlay and replace it with a gdal-python port which only builds python bindings on top of an existing gdal installation. Similar to how gdal allows to build standalone plugins for some formats. I am not 100% sure this will work but it would ease our maintenance effort.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I understand it better, thanks 👍

vcpkg/vcpkg.json Show resolved Hide resolved
@rouault
Copy link
Contributor

rouault commented Jan 21, 2025

Because more drivers, more pleasure

I question a bit that statement, but this is apparently a not so-popular opinion in the community ;-) As white doesn't exist without black, someone has to hate them, so others can have a chance to love them. That said, my cruisade against useless write side of drivers would be well justified when I see the quite impractical UI in QGIS when you have to select the output driver when exporting a raster layer among a dropdown lis of > 50+ candidates that doesn't fit into the screen height, with a lot of them being super obscure, and that's an understatement.

@m-kuhn
Copy link
Member Author

m-kuhn commented Jan 21, 2025

@rouault I agree that if one has to select from a list, more is not always better. But I also think in such a case there are other options like "hide unpopular drivers by default" which sits somewhere between black and white.

This PR was triggered by #60039 (comment) which mentions kea support which in turn made me think that it's probably a thing for some users (on the other hand, this might also be a purely technically motivated statement, I don't know).
freexl is actually almost a no-op, as the library itself is already bundled and just not enabled inside GDAL.

@rouault
Copy link
Contributor

rouault commented Jan 21, 2025

This PR was triggered

no problem. I wasn't questioning the soundness of this PR. KEA is probably in the slightly obscure category, that said that driver has a true originality: it was designed to be a 100% match with the GDAL raster model.

@m-kuhn
Copy link
Member Author

m-kuhn commented Jan 21, 2025

that said that driver has a true originality:

To be kept for a fun fact at an appropriate place and time

@m-kuhn m-kuhn merged commit 282a5a1 into master Jan 21, 2025
35 checks passed
@m-kuhn m-kuhn deleted the m-kuhn-patch-2 branch January 21, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants