-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg] Enable kea and freexl drivers for GDAL #60201
Conversation
Because more drivers, more pleasure
🧮 Vcpkg update reportAdded packages: 🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
@@ -42,8 +42,9 @@ | |||
"expat", | |||
{ | |||
"name": "gdal", | |||
"default-features": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mixed bag of questions:
- default-features were already enabled so far whenever built with bindings, because in the bindings dependency, default-features was not deactivated. This is not expected and actually the change that we want here.
- The decision what's a default feature for gdal is not taken in here, this is mostly a copy of the upstream gdal port with some adjustments for python. Let's not dive into technicalities how it's implemented.
- I would like to get rid of our gdal overlay and replace it with a
gdal-python
port which only builds python bindings on top of an existing gdal installation. Similar to how gdal allows to build standalone plugins for some formats. I am not 100% sure this will work but it would ease our maintenance effort.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I understand it better, thanks 👍
I question a bit that statement, but this is apparently a not so-popular opinion in the community ;-) As white doesn't exist without black, someone has to hate them, so others can have a chance to love them. That said, my cruisade against useless write side of drivers would be well justified when I see the quite impractical UI in QGIS when you have to select the output driver when exporting a raster layer among a dropdown lis of > 50+ candidates that doesn't fit into the screen height, with a lot of them being super obscure, and that's an understatement. |
@rouault I agree that if one has to select from a list, more is not always better. But I also think in such a case there are other options like "hide unpopular drivers by default" which sits somewhere between black and white. This PR was triggered by #60039 (comment) which mentions kea support which in turn made me think that it's probably a thing for some users (on the other hand, this might also be a purely technically motivated statement, I don't know). |
no problem. I wasn't questioning the soundness of this PR. KEA is probably in the slightly obscure category, that said that driver has a true originality: it was designed to be a 100% match with the GDAL raster model. |
To be kept for a fun fact at an appropriate place and time |
Because more drivers, more pleasure