[Backport release-3_40] [GUI] Replace Italic Font with Monospaced Font in Expression Fields of Attribute Table (#59139) #60143
Conversation
… the attribute table. Related to issue qgis#44638 (qgis#59139) * [gui] Remove italics and use monospaced font for expression fields in attribute tableThis commit modifies QgsFieldExpressionWidget to ensure that expression fields in the attribute table are displayed using a regular monospaced font instead of the default italics. This improves readability and ensures consistency between different parts of the interface.- Updated QgsFieldExpressionWidget::updateLineEditStyle() to set font to non-italic and apply monospaced family.- Addressed issue reported in qgis#44638 regarding the readability challenges caused by italicized font in expression fields.Related issue: qgis#44638 * [gui] Reformat code to match standard style
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
|
hey @nirvn , could you please take a look at my PR for the QGIS 3.40 backport? Let me know if there’s anything else you need. Thank you! |
| @@ -392,7 +392,8 @@ void QgsFieldExpressionWidget::updateLineEditStyle( const QString &expression ) | |||
| currentField( &isExpression, &isValid ); | |||
| } | |||
| QFont font = mCombo->lineEdit()->font(); | |||
| font.setItalic( isExpression ); | |||
| font.setFamily( ( QgsCodeEditor::getMonospaceFont() ).family() ); | |||
| font.setItalic( false ); | |||
There was a problem hiding this comment.
Ok for the monospace font, but do we want to set italic to false also for expressions?
There was a problem hiding this comment.
My idea in the original issue was to replicate what is currently seen in the Expression Dialog where italic isn't used. To me, there isn't any benefit using italic in an expression as it can only make it harder to read and easier to misplace the cursor.
There was a problem hiding this comment.
I think visualizing if something is a filed or expression is good, but there may be better options.
In the backport here, I'd leave it as italics.
In master we could try bold for fields and regular for expressions?
|
Pinging @nirvn, who also has issues with the monospace change in master... |
|
The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check
|
github-actions
bot
added
the
stale
|
Reping @nirvn |
github-actions
bot
removed
the
stale
|
Hey there, sorry for not having opined on the original PR. I'm not a huge fan of the change and would consider reverting it prior to the release of 3.42. For one, it's causing some vertical alignment issue in the monospace font combo box over here, and it just looks generally out of place alongside other widgets in quite a few places, e.g.:
Also, I'm very much like @m-kuhn against removing the italic style when the expression is invalid. It provided a good visual feedback that's now just gone for no appealing reason. |
|
I was suggesting the switch for monospace for the sake of concistency with the expression dialog window, but my real grunge is with the italic style that makes it difficult to position the cursor. Reverting to the current default font would be fine if the italic style is omitted. As for a way to alert the user of an invalid expression, would a change of color from black to red be a good alternative? |
|
The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check
|
github-actions
bot
added
the
stale
This PR backports the changes from #59139 to the release-3_40 branch to resolve Issue #44638. The update replaces italic fonts with a monospaced font in the expression fields of the attribute table, enhancing readability and ensuring visual consistency across the interface.