Mesh Layer Rendering with Updated Canvas Fix #59987
Conversation
This reverts commit 5d8fbcc.
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
…on (avoids double rendering of the mesh layer)
| @@ -17184,12 +17184,6 @@ void QgisApp::handleRenderedLayerStatistics() const | |||
| QgsMeshLayer *meshLayer = qobject_cast<QgsMeshLayer *>( QgsProject::instance()->mapLayer( layerStatistics->layerId() ) ); | |||
| if ( meshLayer ) | |||
| { | |||
| QgsMeshRendererSettings rendererSettings = meshLayer->rendererSettings(); | |||
There was a problem hiding this comment.
Where is this logic applied now?
There was a problem hiding this comment.
It is applied in step of renderer creation. Basically, this part of the logic was applied twice, which caused issue (double rendering).
There is significant difference between mesh and raster renderer - mesh renderer is not stored at all, only the settings and mesh renderer is always created when it is needed. Thus there is no refresh of it.
I am not 100% sure that I properly understand the approach that was introduced with QgsRenderedLayerStatistics. Should the layer statistics be only applied on the renderer from this part of the code? And if rendered from anywhere else, just stick with data that are already set in mesh render settings?
|
I updated this to follow the use of On creation of the renderer the This should fix the rendering pipeline, to be correct. |
github-actions
bot
added
the
stale
github-actions
bot
removed
the
stale
src/core/mesh/qgsmeshlayer.cpp
Outdated
| triggerRepaint(); | ||
| if ( repaint ) | ||
| { | ||
| emit rendererChanged(); |
There was a problem hiding this comment.
Do we need to skip emitting the signal too?
If we keep it we can skip the emit meshLayer->legendChanged(); from qgisapp
There was a problem hiding this comment.
Ok, that changed those. This signal is raised and the legendChanged does not
Description
There was a regression in Mesh Layer rendering for scalar datasets in case of "Updated Canvas" extent. This PR fixes it and also fixes fixes issue with style setting panel that could cause QGIS crash (test case was for this was added).
cc @uclaros