fix(featurepool): cache management - fixes #58113

[Djedouas]

This is a PR following the review of #58132 , to facilitate discussion as this is another approach suggested by @nyalldawson .

Geometry checker cache does not work properly with memory layers. refreshCache now handles a list of updated features to be thread-safe.

Also, fixes a locker mode, and correctly remove features from spatial index.

Fixes #58113

[github-actions]

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit 937d061)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 937d061)

[Djedouas]

unrelated test error

[github-actions]

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

• that all unit tests are passing

• that all comments by reviewers have been addressed

• that there is enough information for reviewers, in particular

  • link to any issues which this pull request fixes

  • add a description of workflows which this pull request fixes

  • add screenshots if applicable

• that you have written unit tests where possible
  In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
  If there is no further activity on this pull request, it will be closed in a week.

[Djedouas]

I removed the stale label.

@nyalldawson could you take a look here, please? As this is the new version of #58132 where we discussed together.

Thanks :)

[Djedouas]

@lbartoletti added the suggested modifications

[lbartoletti]

LGTM! This addresses the discussion with nyall - we tested it together, and jacky added the tests and performed the necessary checks. CI is green. I'm going ahead with the merge. We can revisit if any issues arise.