Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CSS margins for block elements in HTML labels #59263

Merged
merged 6 commits into from
Nov 9, 2024

Conversation

nyalldawson
Copy link
Collaborator

Adds support for CSS margin properties for block elements in
the text renderer. Specifically:

  • This is available for block type elements only, eg DIV, P, H1-H6.
  • Margins are NOT available for spans or other non-block content (due to Qt limitations)
  • Margins can be specified in pt units only
  • Margins can be specified either via "margin-left: 5pt; margin-right: 10pt" etc, or "margin: 5pt 0pt 10pt 0pt"
  • Negative margins are supported for the bottom margin ONLY (due to Qt limitations)

Sponsored by City of Freiburg im Breisgau

@nyalldawson nyalldawson added Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Oct 30, 2024
@qgis-bot
Copy link
Collaborator

@nyalldawson

This pull request has been tagged for the changelog.

  • The description will be harvested so please provide a "nearly-ready" text for the final changelog
  • If possible, add a nice illustration of the feature. Only the first one in the description will be harvested (GIF accepted as well)
  • If you can, it's better to give credits to your sponsor, see below for different formats.

You can edit the description.

Format available for credits
  • Funded by NAME
  • Funded by URL
  • Funded by NAME URL
  • Sponsored by NAME
  • Sponsored by URL
  • Sponsored by NAME URL

Thank you!

@qgis-bot
Copy link
Collaborator

@nyalldawson
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

@github-actions github-actions bot added this to the 3.42.0 milestone Oct 30, 2024
Copy link

github-actions bot commented Oct 30, 2024

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit 9250db8)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 9250db8)

@qgis qgis deleted a comment from github-actions bot Oct 30, 2024
@qgis qgis deleted a comment from github-actions bot Oct 30, 2024
Adds support for CSS margin properties for block elements in
the text renderer. Specifically:

- This is available for block type elements only, eg DIV, P, H1-H6.
- Margins are NOT available for spans or other non-block content (due to Qt
  limitations)
- Margins can be specified in pt units only
- Margins can be specified either via "margin-left: 5pt; margin-right:
  10pt" etc, or "margin: 5pt 0pt 10pt 0pt"
- Negative margins are supported for the bottom margin ONLY (due to Qt
  limitations)
@qgis qgis deleted a comment from github-actions bot Oct 31, 2024
@qgis qgis deleted a comment from github-actions bot Oct 31, 2024
@qgis qgis deleted a comment from github-actions bot Oct 31, 2024
@nyalldawson nyalldawson merged commit 5f0b796 into qgis:master Nov 9, 2024
31 checks passed
@nyalldawson nyalldawson deleted the block_margins branch November 9, 2024 22:51
@qgis-bot
Copy link
Collaborator

qgis-bot commented Nov 9, 2024

@nyalldawson
A documentation ticket has been opened at qgis/QGIS-Documentation#9376
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog Items that are queued to appear in the visual changelog - remove after harvesting Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants