Layout better node item creation #59239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
YoannQDQ
added
Feature
Bug
YoannQDQ
force-pushed
the
layout-fix-node-item-creation
branch
2 times, most recently
from
32e3ec8 to
21a6a50
Compare
troopa81
reviewed
Nov 6, 2024
There was a problem hiding this comment.
If I understand correctly what you propose, you want to add a red dot line different for the temporary/last added part of the polygon while the rest is a red plain line.
I don't know much about this area of the code. Instead of adding a new createTemporaryNodeItemRubberBand and all the related code, could we not return a QGraphicsItem which aggregate two item (one plain line et one dotted?)
YoannQDQ
force-pushed
the
layout-fix-node-item-creation
branch
3 times, most recently
from
9b65cf6 to
93eaf04
Compare
YoannQDQ
force-pushed
the
layout-fix-node-item-creation
branch
from
93eaf04 to
c5d0ac4
Compare
YoannQDQ
force-pushed
the
layout-fix-node-item-creation
branch
from
c5d0ac4 to
997fdd7
Compare
YoannQDQ
force-pushed
the
layout-fix-node-item-creation
branch
from
997fdd7 to
ccb5542
Compare
YoannQDQ
force-pushed
the
layout-fix-node-item-creation
branch
from
ccb5542 to
14ce7ea
Compare
nyalldawson
reviewed
Dec 11, 2024
YoannQDQ
force-pushed
the
layout-fix-node-item-creation
branch
from
cd7bf6a to
f4d991f
Compare
nyalldawson
approved these changes
Dec 12, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a secondary rubberband in node item creation tools to better show the polyline / polygon being traced, which match the digitizing tools behavior.
Tracing a new node item now clears the current selection.
Also fix pressing Backspace/Del keypress removes the last node. It was "eaten" by the global QShortcut that deletes the current item.
Before (Not possible to remove point, unclear what polygon will actually be drawn if one right-clicks)
After