[cmake] Create one command for many resources in ADD_QGIS_RESOURCES #59232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of creating a single command for EVERY resource, just build up a single command for ALL the resources. This avoids thousands of lines of output when compiling, where we get one line per resource file. Eg: [890/11818 452.2/sec] Generating ../../output/data/svg/sport/sport_snooker.svg [891/11818 451.8/sec] Generating ../../output/data/svg/sport/sport_soccer.svg Since we're installing thousands and thousands of resources (eg the svg symbols, cpt color ramp data, etc), this is all just noise. And it's especially annoying on github runs where the sheer length of the build log drags the whole page to a crawl! This change reduces the total steps from ~11800 (as above), to ~5900
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
nyalldawson
force-pushed
the
less_cmake_output
branch
from
2c221c8 to
31fb10f
Compare
m-kuhn
reviewed
Oct 27, 2024
m-kuhn
reviewed
Oct 27, 2024
Co-authored-by: Matthias Kuhn <[email protected]>
m-kuhn
approved these changes
Oct 27, 2024
|
Thanks @m-kuhn ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of creating a single command for EVERY resource, just build up a single command for ALL the resources.
This avoids thousands of lines of output when compiling, where we get one line per resource file. Eg:
Since we're installing thousands and thousands of resources (eg the svg symbols, cpt color ramp data, etc), this is all just noise. And it's especially annoying on github runs where the sheer length of the build log drags the whole page to a crawl!
This change reduces the total steps from ~11800 (as above), to ~5900
(maybe if we're lucky it'll speed up compilations too, as eg ninja may be able to make more intelligent decisions when pooling jobs)