[CMYK] Add API color model and profile methods to project #58056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API allows to define a color model without a color space. If both are set, consistency between defined color model and color space one is checked (only in Qt version 6.8.0 or greater because it's not possible to retrieve color model from color space before that)
troopa81
added
Feature
Print Layouts
nyalldawson
reviewed
Jul 10, 2024
|
Looking good! (The bulk of the comments above are just grammar fixes on the docs) |
nyalldawson
added
API
|
@nyalldawson Thank you for your review and your suggestions! I treated all of them except for replacing parameter I choose to write it the Qt way
|
nyalldawson
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another PR regarding qgis/QGIS-Enhancement-Proposals#283
API allows to define a color model without a color space. If both are set, consistency between defined color model and color space one is checked (only in Qt version 6.8.0 or greater because it's not possible to retrieve color model from color space before that)
Contrary to what was stated in the QEP there is no default CMYK ICC profile. User has the ability to select a CMYK color model without ICC profile. If a ICC profile is set, a PDF/X-4 (ready-for-printing) PDF with the ICC profile embedded will be generated when exporting a layout, else a classic PDF 1.4 will be generated.
Funded by Métropôle de Bordeaux