Fix: build with QTSERIALPORT=false
#56953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes: qgis#56944 Signed-off-by: t0b3 <[email protected]>
Signed-off-by: t0b3 <[email protected]>
m-kuhn
reviewed
Mar 24, 2024
| @@ -91,21 +91,24 @@ done: | |||
|
|
|||
| %End | |||
|
|
|||
| %Feature HAVE_GUI | |||
| %Feature HAVE_QTSERIALPORT | |||
There was a problem hiding this comment.
Do we need all the other features?
There was a problem hiding this comment.
@m-kuhn hmm, that's a good question - It was already there... just tell me if you feel some of them should be removed in this PR as well 👍
There was a problem hiding this comment.
@m-kuhn sure they were ... just a few lines lower ... and they need to be introduced before %If (<your_feature>) that's why I suggest to shift them all together
m-kuhn
approved these changes
Mar 24, 2024
| @@ -91,21 +91,24 @@ done: | |||
|
|
|||
| %End | |||
|
|
|||
| %Feature HAVE_GUI | |||
| %Feature HAVE_QTSERIALPORT | |||
This was referenced Mar 24, 2024
Closed
3nids
reviewed
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
QTSERIALPORT=falsegithub.actor != 'qgis'so GH actions in forked repos won't fail for this reasonBackport
#Fixes #56944