suggest to fix topological mesh error when starting mesh editing #50310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcloarec
added
Bug
vcloarec
added
the
Mesh
vcloarec
force-pushed
the
fixBrokengMesh
branch
from
7309e54 to
49b8da8
Compare
uclaros
approved these changes
Oct 20, 2022
Co-authored-by: Stefanos Natsis <[email protected]>
Co-authored-by: Stefanos Natsis <[email protected]>
Co-authored-by: Stefanos Natsis <[email protected]>
Co-authored-by: Stefanos Natsis <[email protected]>
vcloarec
force-pushed
the
fixBrokengMesh
branch
from
29d6f00 to
2b4395a
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #50041 and #50062
It may happen that an editable mesh has topological errors that could prevent entering edit mode. The worst case is when the user edits a mesh, QGIS crashes and when he tries to restart editing, a topological error appeared and the user is unable to
modify the mesh... I didn't identify the reason because there is a check before saving the mesh, but apparently it happened. This leads to losing all the work on the mesh, even the saved work.
So, with this PR, when a topological prevents to enter editing mode, the following message box appears:
(here we can see a "manifold face", that is a face that cover another one, a quad).
If the user clicks "Yes", the mesh is fixed: