Fix QgsAbstractRelationEditorWidget inconsistency NmRelation / NmRelationId #42296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mNmRelation and nNmRelationId represent the same QgsRelation instance but it was possible to set them to different values. Also added method nmRelation() to access the nmRelation directly.
suricactus
approved these changes
Mar 17, 2021
|
I think the failing test is unrelated to the pr... can someone restart it please? |
|
@domi4484 I'm working to fix the WMS tests, you can ignore the failure for now. |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 29, 2021
Fix QgsAbstractRelationEditorWidget inconsistency NmRelation / NmRelationId
3nids
pushed a commit
that referenced
this pull request
Mar 29, 2021
Fix QgsAbstractRelationEditorWidget inconsistency NmRelation / NmRelationId Co-authored-by: Matthias Kuhn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QgsAbstractRelationEditorWidget members mNmRelation and mNmRelationId represent the same QgsRelation instance but it was possible to set them to different values which lead to inconsistency.
Also added method nmRelation() to access the nmRelation directly.