Advanced digitizing - circle intersection #9569

selmaVH1 · 2025-01-17T17:09:40Z

Goal:

Ticket(s): #

Backport to LTR documentation is requested

DelazJ · 2025-01-18T06:22:09Z

docs/user_manual/working_with_vector/editing_geometry_attributes.rst

+---------------------------
+
+To find the intersection point of two circles, click the
+|circleIntersection| :sup:`2-circle Point Intersection` icon.


Given that this button is not directly exposed in the toolbar, for people that would arrive directly to this section, let's add where to find it

Suggested change

|circleIntersection| :sup:`2-circle Point Intersection` icon.

|circleIntersection| :sup:`2-circle Point Intersection` icon

in the |extractVertices| :sup:`Construction Tools` drop-down menu.

DelazJ · 2025-01-18T06:22:37Z

docs/user_manual/working_with_vector/editing_geometry_attributes.rst

+
+To find the intersection point of two circles, click the
+|circleIntersection| :sup:`2-circle Point Intersection` icon.
+This will open a dialog where you can define the parametaers for


Suggested change

This will open a dialog where you can define the parametaers for

This will open a dialog where you can define the parameters for

DelazJ · 2025-01-18T06:25:08Z

docs/user_manual/working_with_vector/editing_geometry_attributes.rst

+2-circle point intersection
+---------------------------
+
+To find the intersection point of two circles, click the


Assuming there is no "pick"...

Suggested change

To find the intersection point of two circles, click the

To add a vertex at the intersection of two circles, click the

DelazJ · 2025-01-18T08:27:42Z

docs/user_manual/working_with_vector/editing_geometry_attributes.rst

+    It is even possible to hover over two different vertices, generating virtual
+    coordinate lines for both, and snap to their intersection.
+* |circleIntersection| :sup:`2-circle Point Intersection`: allows you to
+  pick or digitize a point at the intersection of two circles.


What is meant by "pick", here? Catch? How? @nirvn

Suggested change

pick or digitize a point at the intersection of two circles.

digitize a point or vertex at the intersection of two circles.

DelazJ · 2025-01-19T05:19:18Z

docs/user_manual/working_with_vector/editing_geometry_attributes.rst

+based on your clicks on the map canvas.
+You will need to enter the distance :guilabel:`d` for each circle, the tool will then calculate
+and display the two intersection points of the circles.
+


Suggested change

Click one of them to add the new vertex.

And maybe the above should be as steps..

DelazJ · 2025-01-19T05:31:43Z

docs/user_manual/working_with_vector/img/circles_intersection.png

Do we need the advanced digitizing panel, here? I find the two other elements enough complementary, and we would avoid adding "unnecessary" elements that may look outdated in a few releases, e.g. because of new tools/options in GUI.
But if we do, can it be placed on the left of the circles, to get a more landscaped image and less blank part in a higher image, in docs? Thanks.

DelazJ · 2025-01-19T05:37:30Z

docs/user_manual/working_with_vector/img/advanced_digitizing.png

Not willing to nitpick but can you add the dialog with more buttons enabled. The perpendicular and parallel buttons should at least be clearly identifiable.

DelazJ · 2025-01-19T05:45:31Z

substitutions.txt

@@ -218,6 +218,8 @@
   :width: 1.5em
 .. |circleCenterPoint| image:: /static/common/mActionCircleCenterPoint.png
   :width: 1.5em
+.. |circleIntersection| image:: /static/common/circlesintersection.png


This should be |circlesintersection|, given the filename. Or we rename the icon in code repo for consistency with others...

Yes, I follow the docs guidelines: "The replacement text should be derived from the file name and written in camelCase."

Indeed. I'm mixing requirements of my long time plan of automatizing substitutions addition process with actual rules. Sorry.
Then it should be circlesIntersection, here.

Suggested change

.. |circleIntersection| image:: /static/common/circlesintersection.png

.. |circlesIntersection| image:: /static/common/circlesintersection.png

DelazJ

Should be good to merge then

DelazJ · 2025-01-22T05:54:23Z

substitutions.txt

@@ -218,6 +218,8 @@
   :width: 1.5em
 .. |circleCenterPoint| image:: /static/common/mActionCircleCenterPoint.png
   :width: 1.5em
+.. |circleIntersection| image:: /static/common/circlesintersection.png


Indeed. I'm mixing requirements of my long time plan of automatizing substitutions addition process with actual rules. Sorry.
Then it should be circlesIntersection, here.

Suggested change

.. |circleIntersection| image:: /static/common/circlesintersection.png

.. |circlesIntersection| image:: /static/common/circlesintersection.png

DelazJ · 2025-01-22T08:31:56Z

docs/user_manual/working_with_vector/editing_geometry_attributes.rst

@@ -2156,6 +2182,8 @@ To edit features in-place:
   :width: 1.5em
 .. |circleCenterPoint| image:: /static/common/mActionCircleCenterPoint.png
   :width: 1.5em
+.. |circleIntersection| image:: /static/common/circlesintersection.png


Suggested change

.. |circleIntersection| image:: /static/common/circlesintersection.png

.. |circlesIntersection| image:: /static/common/circlesintersection.png

DelazJ · 2025-01-22T08:32:17Z

docs/user_manual/working_with_vector/editing_geometry_attributes.rst

+
+To add a vertex at the intersection of two circles, follow these steps:
+
+#. Click the |circleIntersection| :sup:`2-circle Point Intersection` icon in the


Suggested change

#. Click the |circleIntersection| :sup:`2-circle Point Intersection` icon in the

#. Click the |circlesIntersection| :sup:`2-circle Point Intersection` icon in the

DelazJ · 2025-01-22T08:34:21Z

docs/user_manual/working_with_vector/editing_geometry_attributes.rst

+* |circleIntersection| :sup:`2-circle Point Intersection`: allows you to
+  digitize a point or vertex at the intersection of two circles.
+  (more at :ref:`circle_intersection`).


should be indented

Suggested change

* |circleIntersection| :sup:`2-circle Point Intersection`: allows you to

digitize a point or vertex at the intersection of two circles.

(more at :ref:`circle_intersection`).

* |circlesIntersection| :sup:`2-circle Point Intersection`: allows you to

digitize a point or vertex at the intersection of two circles.

(more at :ref:`circle_intersection`).

Sorry, I don’t understand why it needs to be indented, as it’s in line with the other items. If we indent it, I’m afraid it might look like it belongs to the construction tools...

@nirvn @DelazJ Sorry, my mistake. So, the tool from which we get the (drop-down) 2-circle point intersection does not have a tooltip in the GUI, but we can call it 'construction tools'? We describe it that way, but I'm not sure now...

So, the tool from which we get the (drop-down) 2-circle point intersection does not have a tooltip in the GUI

Indeed. I asked for a name at qgis/QGIS#57648 (comment). Let's expect we get something...

but we can call it 'construction tools'? We describe it that way, but I'm not sure now...

No "Construction tools" is the one on the left so can't be used. Let's remove that mention in the meantime (and ignore the drop-down)

Backports #9569

Advanced digitizing - circle intersection

f4bcb32

DelazJ added Editing backport release_3.40 On merge create a backported pull request to 3.40 Vector labels Jan 19, 2025

DelazJ reviewed Jan 19, 2025

View reviewed changes

Suggestions added

9288b74

DelazJ approved these changes Jan 22, 2025

View reviewed changes

selmaVH1 added 2 commits January 22, 2025 10:10

substitutions fix

116f41c

Fixes for 2-circle point intersection

40ca5ba

DelazJ merged commit 253e438 into qgis:master Jan 22, 2025
3 checks passed

qgis-bot mentioned this pull request Jan 22, 2025

[Backport release_3.40] Advanced digitizing - circle intersection #9579

Merged

DelazJ added a commit that referenced this pull request Jan 22, 2025

Advanced digitizing - circle intersection (#9579)

d6e7d58

Backports #9569

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Advanced digitizing - circle intersection #9569

Advanced digitizing - circle intersection #9569

selmaVH1 commented Jan 17, 2025

DelazJ Jan 18, 2025

DelazJ Jan 18, 2025

DelazJ Jan 18, 2025

DelazJ Jan 18, 2025

DelazJ Jan 19, 2025

DelazJ Jan 19, 2025

DelazJ Jan 19, 2025

DelazJ Jan 19, 2025

selmaVH1 Jan 21, 2025

DelazJ Jan 22, 2025

DelazJ left a comment

DelazJ Jan 22, 2025

DelazJ Jan 22, 2025

DelazJ Jan 22, 2025

DelazJ Jan 22, 2025

selmaVH1 Jan 22, 2025

selmaVH1 Jan 22, 2025 •

edited

Loading

DelazJ Jan 22, 2025

	\|circleIntersection\| :sup:`2-circle Point Intersection` icon.
	\|circleIntersection\| :sup:`2-circle Point Intersection` icon
	in the \|extractVertices\| :sup:`Construction Tools` drop-down menu.

	This will open a dialog where you can define the parametaers for
	This will open a dialog where you can define the parameters for

	To find the intersection point of two circles, click the
	To add a vertex at the intersection of two circles, click the

	pick or digitize a point at the intersection of two circles.
	digitize a point or vertex at the intersection of two circles.

	.. \|circleIntersection\| image:: /static/common/circlesintersection.png
	.. \|circlesIntersection\| image:: /static/common/circlesintersection.png


		To add a vertex at the intersection of two circles, follow these steps:

		#. Click the \|circleIntersection\| :sup:`2-circle Point Intersection` icon in the

	#. Click the \|circleIntersection\| :sup:`2-circle Point Intersection` icon in the
	#. Click the \|circlesIntersection\| :sup:`2-circle Point Intersection` icon in the

Advanced digitizing - circle intersection #9569

Advanced digitizing - circle intersection #9569

Conversation

selmaVH1 commented Jan 17, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DelazJ left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

selmaVH1 Jan 22, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

selmaVH1 Jan 22, 2025 •

edited

Loading