-
-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add masking training #9140
Add masking training #9140
Conversation
Looks like there is a CI issue not related with my modifications |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @troopa81
Some feedback below. I mainly miss screenshots. We sometimes are trying to describe the GUI while a screenshot would have made things clearer.
Co-authored-by: Harrissou Sant-anna <[email protected]>
Co-authored-by: Harrissou Sant-anna <[email protected]>
Co-authored-by: Harrissou Sant-anna <[email protected]>
Co-authored-by: Harrissou Sant-anna <[email protected]>
Co-authored-by: Harrissou Sant-anna <[email protected]>
Co-authored-by: Harrissou Sant-anna <[email protected]>
Co-authored-by: Harrissou Sant-anna <[email protected]>
Co-authored-by: Harrissou Sant-anna <[email protected]>
Co-authored-by: Harrissou Sant-anna <[email protected]>
Co-authored-by: Harrissou Sant-anna <[email protected]>
Thank you for your thorough and relevant review @DelazJ 🙏 I treated all of your comments and added all the required screenshots |
Thanks @troopa81. I made a quick read-up and LGTM. If there are no open points, I'm OK with merging. Do you want to properly squash the commits yourself or I do it while merging? |
You can squash and merge! Thanks @DelazJ |
Add selective masking training content.
This requires some training data related to this PR qgis/QGIS-Training-Data#60