Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add masking training #9140

Merged
merged 19 commits into from
Jul 19, 2024
Merged

Add masking training #9140

merged 19 commits into from
Jul 19, 2024

Conversation

troopa81
Copy link
Contributor

@troopa81 troopa81 commented Jun 17, 2024

Add selective masking training content.

This requires some training data related to this PR qgis/QGIS-Training-Data#60

@troopa81
Copy link
Contributor Author

Looks like there is a CI issue not related with my modifications

Copy link
Collaborator

@DelazJ DelazJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @troopa81
Some feedback below. I mainly miss screenshots. We sometimes are trying to describe the GUI while a screenshot would have made things clearer.

docs/training_manual/basic_map/symbology.rst Outdated Show resolved Hide resolved
docs/training_manual/basic_map/symbology.rst Outdated Show resolved Hide resolved
docs/training_manual/basic_map/symbology.rst Outdated Show resolved Hide resolved
docs/training_manual/basic_map/symbology.rst Show resolved Hide resolved
docs/training_manual/basic_map/symbology.rst Outdated Show resolved Hide resolved
docs/training_manual/basic_map/symbology.rst Outdated Show resolved Hide resolved
docs/training_manual/basic_map/symbology.rst Outdated Show resolved Hide resolved
docs/training_manual/basic_map/symbology.rst Outdated Show resolved Hide resolved
docs/training_manual/basic_map/symbology.rst Outdated Show resolved Hide resolved
docs/training_manual/basic_map/symbology.rst Outdated Show resolved Hide resolved
troopa81 and others added 15 commits July 16, 2024 15:51
Co-authored-by: Harrissou Sant-anna <[email protected]>
Co-authored-by: Harrissou Sant-anna <[email protected]>
Co-authored-by: Harrissou Sant-anna <[email protected]>
Co-authored-by: Harrissou Sant-anna <[email protected]>
Co-authored-by: Harrissou Sant-anna <[email protected]>
Co-authored-by: Harrissou Sant-anna <[email protected]>
Co-authored-by: Harrissou Sant-anna <[email protected]>
Co-authored-by: Harrissou Sant-anna <[email protected]>
Co-authored-by: Harrissou Sant-anna <[email protected]>
Co-authored-by: Harrissou Sant-anna <[email protected]>
@troopa81
Copy link
Contributor Author

Thank you for your thorough and relevant review @DelazJ 🙏

I treated all of your comments and added all the required screenshots

@DelazJ DelazJ added the squash! label Jul 19, 2024
@DelazJ
Copy link
Collaborator

DelazJ commented Jul 19, 2024

Thanks @troopa81. I made a quick read-up and LGTM. If there are no open points, I'm OK with merging. Do you want to properly squash the commits yourself or I do it while merging?

@troopa81
Copy link
Contributor Author

You can squash and merge!

Thanks @DelazJ

@DelazJ DelazJ merged commit 4ee02cd into qgis:master Jul 19, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants