-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blog afi #14 #16
base: master
Are you sure you want to change the base?
Blog afi #14 #16
Conversation
* Add notebook template * Add AFI notebook and modify Dockerfile * gti clone changes * git clone branches * Update sos's * Add matplotlib * Change git checkout commit number * Fixes to figures
@jvelazquez-reyes I think I found the source of the bug in your notebook where it says it can't find I think it's not the class that it can't find, but a property of another help tool that we've developed. Here's the error: loading struct
loading io
loading statistics
loading optim
loading image
warning: load: '/home/jovyan/work/t1_notebooks/qMRLab/docs/iqmr_gethelp.mat' found by searching load path
warning: called from
qMRinfo at line 15 column 8
get_MRIinputs_optional at line 130 column 20
sanityCheck at line 73 column 27
FitData at line 37 column 1
error: structure has no member 'b1_afi'
error: called from
qMRinfo at line 17 column 21
get_MRIinputs_optional at line 130 column 20
sanityCheck at line 73 column 27
FitData at line 37 column 1
In short, I think you haven't completed all the steps to create a new qMRLab model (https://github.com/qMRLab/qMRLab/wiki/Guideline:-Adding-a-new-Model) - see point 11 from that link. @agahkarakuzu can provide more guidance on how to complete a model if you have questions. |
@jvelazquez-reyes In addition to Figure 8 that's not working yet because of the issue above, Figure 4 seems to be broken as well. It appears that you tried to implement two sliders in a figure, but does Plotly allow for that? Did you have it working on your end at one time? |
Hi @mathieuboudreau and @agahkarakuzu I added the =============== qMRLab::Fit ======================
Operation has been started: b1_afi
error: 'medfilt3' undefined near line 108 column 28
error: called from
medianFilt at line 108 column 26
fit at line 74 column 39
fit at line 88 column 37
FitData at line 261 column 9 This is happening because in the inheritance to the I was testing step 7 (https://github.com/qMRLab/qMRLab/wiki/Guideline:-Adding-a-new-Model). |
Yup, my bad. Resolved in : qMRLab/qMRLab@b2494b6 |
After scratching my head about this problem, I think I found the problem and resolved it. You set up the model as we instructed, and I compared it with another similar model (b1_dam) and they appeared to match. What I think was causing the problem was actually my fault; when I uploaded the AFI data to OSF, I uploaded the images ass |
Yes, uploading the images as Also, Figure 8 of the notebook is ok once the Polynomial (in FilterClass) was reverted to be the default option. |
@jvelazquez-reyes we never did publish this blog post, correct? Would you like to revisit this and complete it so that we may have an additional blog post? |
Continuation of the PR from #14