Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filename variations to AWS MWR L1C #3039

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add filename variations to AWS MWR L1C #3039

wants to merge 2 commits into from

Conversation

TAlonglong
Copy link
Collaborator

Add filename variations to AWS MWR L1C

@TAlonglong TAlonglong self-assigned this Jan 22, 2025
@coveralls
Copy link

coveralls commented Jan 22, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13113051862

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.217%
Totals Coverage Status
Change from base Build 12892083039: 0.0%
Covered Lines: 53688
Relevant Lines: 55799
💛 - Coveralls

@TAlonglong TAlonglong requested a review from adybbroe January 23, 2025 06:41
adybbroe
adybbroe requested changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@adybbroe adybbroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, and well spotted. I think we should update/clean the l1b and the sterna reader yaml as well, just keeping the general specification with the mission-type and environment and skipping the specific ones.

@TAlonglong
Copy link
Collaborator Author

You mean like this? Or is there also a third place I should update when at it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adybbroe adybbroe adybbroe requested changes

@djhoese djhoese Awaiting requested review from djhoese djhoese is a code owner

@mraspaud mraspaud Awaiting requested review from mraspaud mraspaud is a code owner

Assignees

@TAlonglong TAlonglong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support variations of AWS MWR L1C filename
3 participants
@TAlonglong @coveralls @adybbroe